Add ACTS tracking in all CIs #1518
Conversation
| # The Tracking modules produce a lot of helpful messages | ||
| # but (at the debug level) is too much for commiting the gold log | ||
| # into the git working tree on GitHub | ||
| p.termLogLevel = 0 |
There was a problem hiding this comment.
Do you want to use the newer syntax? (I also want to double check that #1458 works.)
| p.termLogLevel = 0 | |
| p.logger.termLevel = 0 |
I agree with this comment, but even more so, I think whatever has been settled on in recent tracking optimizations should go in as defaults for all these processors, and not be specified in detail here. As @tomeichlersmith pointed out, the validation configs are very useful examples and having people set all kinds of variables themselves is not sustainable in the long term. |
|
@bloodyyugo @EBerzin can you please confirm? |
Yeah, these values are good. Setting them as default values is a good idea, but we use the same class for both tagger and recoil tracking and they potentially have different values (though right now they are so loose they might as well be the same). That said, we could easily add a switch to tell the code if it's doing tagger or recoil and set the parameters appropriately. I plan on changing how these cuts are implemented in the nearish future, so I can add this then. |
|
The values look good for the tagger. But these config files use |
Co-authored-by: Tom Eichlersmith <[email protected]>
|
OK I suggest we do this in two steps, like that the CI tests will actually show the improvements with the full suite of tracking in Elisabeth's PR |
|
Thanks @bloodyyugo and @EBerzin for checking the numbers. Great to hear that the tracking parameters are going to be updated. How about we do it this way. @tvami removes the specific parameters being set from these configs, and when you update the defaults to the better ones, the CI test will show the difference it makes? |
|
Haha @tvami is clearly onboard at least :) |
* Add ACTS tracking in all CIs * Dont switch the tracking in ecal on yet * Move to `ldmx-reduced-v2` in CI * Move to p.logger for logging --------- Co-authored-by: Tom Eichlersmith <[email protected]>
* Add ACTS tracking in all CIs * Dont switch the tracking in ecal on yet * Move to `ldmx-reduced-v2` in CI * Move to p.logger for logging --------- Co-authored-by: Tom Eichlersmith <[email protected]>
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
First step to resolve #1517
Resolves #1487
Check List